swev-id: matplotlib__matplotlib-25960 honor subfigure spacing#68
Open
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25960from
Open
swev-id: matplotlib__matplotlib-25960 honor subfigure spacing#68casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25960from
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25960from
Conversation
Author
Local Validation
|
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Solid fix. SubFigure now reuses GridSpec spacing logic so the manual wspace/hspace gaps materialize in the non-constrained path while bboxes provided by constrained layout stay untouched. New geometry assertions cover horizontal, vertical, default, and nested scenarios. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue
Fixes #64
Reproduction Steps
pytest lib/matplotlib/tests/test_figure.py -k 'subfigures_wspace_spacing or subfigures_hspace_spacing or nested_subfigures_inherit_spacing'Observed Failure (pre-fix)
Fix